ソースを参照

fix handling routing error during debug webshot

Mike L 3 年 前
コミット
1f9c50bce0
2 ファイル変更6 行追加2 行削除
  1. 3 1
      dist/webshot.js
  2. 3 1
      src/webshot.ts

+ 3 - 1
dist/webshot.js

@@ -163,7 +163,9 @@ class Webshot extends CallableInstance {
                             const path = temp.path({ suffix: '.html' });
                             (0, fs_1.writeFileSync)(path, html);
                             logger.warn(`saved debug html to ${path}`);
-                        }).then(() => page.route('**/*', route => route.abort())).then(() => page.screenshot({ fullPage: true })).then(screenshot => {
+                        }).then(() => page.route('**/*', route => route.abort().catch(err => {
+                            logger.error(`error aborting all requests for debug screenshot, error: ${err}`);
+                        }))).then(() => page.screenshot({ fullPage: true })).then(screenshot => {
                             sharpToFile(sharp(screenshot).jpeg({ quality: 90 })).then(fileUri => {
                                 logger.warn(`saved debug screenshot to ${fileUri.substring(7)}`);
                             });

+ 3 - 1
src/webshot.ts

@@ -200,7 +200,9 @@ class Webshot extends CallableInstance<[Tweet[], (...args) => void, number], Pro
                 const path = temp.path({suffix: '.html'});
                 writeFileSync(path, html);
                 logger.warn(`saved debug html to ${path}`);
-              }).then(() => page.route('**/*', route => route.abort())
+              }).then(() => page.route('**/*', route => route.abort().catch(err => {
+                logger.error(`error aborting all requests for debug screenshot, error: ${err}`);
+              }))
               ).then(() => page.screenshot({fullPage: true})).then(screenshot => {
                 sharpToFile(sharp(screenshot).jpeg({ quality: 90 })).then(fileUri => {
                   logger.warn(`saved debug screenshot to ${fileUri.substring(7)}`);